Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] port l10n_it_account_stamp_ddt #1575

Merged
merged 5 commits into from
Jan 13, 2020
Merged

[12.0] port l10n_it_account_stamp_ddt #1575

merged 5 commits into from
Jan 13, 2020

Conversation

sergiocorato
Copy link
Contributor

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@OCA-git-bot
Copy link
Contributor

Hi @tafaRU,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot mentioned this pull request Jan 4, 2020
Closed
35 tasks
@sergiocorato sergiocorato changed the title [IMP] port l10n_it_account_stamp_ddt to 12.0 [12.0] port l10n_it_account_stamp_ddt Jan 4, 2020
@sergiocorato sergiocorato force-pushed the 12.0-mig-l10n_it_account_stamp_ddt branch from 684b371 to cf70114 Compare January 4, 2020 22:30
tafaRU
tafaRU requested changes Jan 7, 2020
View reviewed changes
l10n_it_account_stamp_ddt/__manifest__.py Outdated
# Copyright 2019 Alex Comba - Agile Business Group
# Copyright 2020 Sergio Corato <https://github.com/sergiocorato>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

come mai hai aggiunto il tuo Copyright?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corretto

l10n_it_account_stamp_ddt/__manifest__.py Outdated
'category': 'Localization/Italy',
'license': 'AGPL-3',
'author': 'Agile Business Group, Odoo Community Association (OCA)',
'maintainers': ['tafaRU'],
'website': 'https://github.com/OCA/l10n-italy/tree/10.0/'
'l10n_it_account_stamp_ddt',
'website': 'https://github.com/OCA/l10n-italy',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potresti mantenere il pattern precedente?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fatto

@tafaRU
Copy link
Member

tafaRU commented Jan 7, 2020

@sergiocorato, grazie! Per favore, oltre alle richieste precedenti, ti chiedo di modificare il commit message in [MIG] l10n_it_account_stamp_ddt: Migration to 12.0 come da linee guida.

@sergiocorato sergiocorato force-pushed the 12.0-mig-l10n_it_account_stamp_ddt branch from cf70114 to c6f4b39 Compare January 8, 2020 13:01
@sergiocorato sergiocorato force-pushed the 12.0-mig-l10n_it_account_stamp_ddt branch from c6f4b39 to effe9cc Compare January 8, 2020 13:03
@sergiocorato
Copy link
Contributor Author

@sergiocorato, grazie! Per favore, oltre alle richieste precedenti, ti chiedo di modificare il commit message in [MIG] l10n_it_account_stamp_ddt: Migration to 12.0 come da linee guida.

fatto, grazie!

eLBati
eLBati approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eLBati
Copy link
Member

eLBati commented Jan 13, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-1575-by-eLBati-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 13, 2020
@OCA-git-bot
Merge PR #1575 into 12.0
bf529df 
Signed-off-by eLBati
@OCA-git-bot
Copy link
Contributor

@eLBati your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1575-by-eLBati-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@eLBati
Copy link
Member

eLBati commented Jan 13, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-1575-by-eLBati-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 13, 2020
@OCA-git-bot
Merge PR #1575 into 12.0
6faf558 
Signed-off-by eLBati
@OCA-git-bot OCA-git-bot merged commit effe9cc into OCA:12.0 Jan 13, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a452173. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati approved these changes

@tafaRU tafaRU tafaRU approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sergiocorato @OCA-git-bot @tafaRU @eLBati @francesco-ooops @oca-travis